Setting the Spotify API Client and Secret via UI stores in wrong key #10
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Investigation
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
spotizerrphoenix/spotizerr-phoenix#10
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Describe the bug
I originally used my main account for the Spotify Api credentials and I wanted to switch to an alt. When updating the credentials via the UI, it adds snake_case keys to the config in addition to the existing camelCase keys.
To Reproduce
Precise steps to reproduce the behavior (start from how you built your container):
docker compose up(clicked from UI in unraid docker compose plugin)client_id&clientIDas well asclient_secret&clientSecretExpected behavior
Updating through UI should update the credentials successfully
Desktop):
docker-compose.yaml
.env
Config
Version
v4.0.13
interesting thanks for pointing this out. haven't made any changes related to this so looks like a regression from the previous repo
after some investigation the config/server page is using a generalized/generic api client which saves the config but takes the whole payload and adds it to the main.json, even though this should be separated specifically for the api credentials.
data/creds/search.jsoninstead ofdata/config/main.jsonmain.jsonto camelCase which is reason for seeing both in main.json even though the api search creds should not exist in main.jsondata/creds/search.jsonwith the correct client_id and client_secretdata/config/main.json: remove both camelCased & snake_cased versions of client id and secret@bortsampson89 fixed in version
4.0.14: https://lavaforge.org/spotizerrphoenix/spotizerr-phoenix/releases/tag/v4.0.14fix: Setting the Spotify API Client and Secret via UI stores in wrong key #10
data/config/main.jsondata/creds/search.jsonafter updating your image to latest (
spotizerrphoenix/spotizerr)data/config/main.jsonif they exist there